P1B: Refactor (packages/ui/src/theme/v2/avatar.ts): Remove duplicated avatar token definitions - #49

Issue for this PR

Closes #47

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

Qlty reported duplicated code between V2_AVATAR_LIGHT and V2_AVATAR_DARK in packages/ui/src/theme/v2/avatar.ts. I refactored the repeated avatar token structure into a shared helper function while keeping the same light and dark color values. This removes the duplication without changing the output of the avatar theme tokens.

I also added tests for both the light and dark avatar tokens to make sure the refactor keeps the existing values.

How did you verify your code works?

I ran the tests for the UI package and the new avatar tests passed. I also generated a coverage report, which shows src/theme/v2/avatar.ts at 100% function and line coverage.

I reran Qlty on packages/ui/src/theme/v2/avatar.ts after the refactor and the duplicated-code smell is no longer reported.

Commands used:

bun test ./src/theme/v2/avatar.test.ts

bun test

bun test --coverage --coverage-dir=./coverage

qlty smells --no-snippets packages/ui/src/theme/v2/avatar.ts

Screenshots / recordings

Before Qlty:

After Qlty:

Avatar tests passing:

UI package tests:

Test coverage:

Lint:

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR